feat: reworked markdown tables according to new design #4088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request reworks table rendering and associated UI kit components to align with the new design specifications.
- In the Kotlin HTML renderer, a new div container is wrapped around table elements to support updated styling.
- In the UI kit package, module exports have been refactored to use explicit re-exports, and a new table style import has been added.
- In the component creator script, the generated index file now uses an export statement to reflect the intended module structure.
Reviewed Changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dokka-subprojects/plugin-base/src/main/kotlin/org/jetbrains/dokka/base/renderers/html/HtmlRenderer.kt | Added a div with class "table--container" wrapping the table element for new design support |
| dokka-subprojects/plugin-base-frontend/src/main/ui-kit/table/index.ts | Introduced a SCSS import to include table-specific styling |
| dokka-subprojects/plugin-base-frontend/src/main/ui-kit/index.ts | Refactored module exports to individual "export * as" statements |
| dokka-subprojects/plugin-base-frontend/create-component.mjs | Updated the generated file content to use an export statement rather than an import |
Files not reviewed (4)
- dokka-subprojects/plugin-base-frontend/src/main/ui-kit/table/styles.scss: Language not supported
- dokka-subprojects/plugin-base/src/main/resources/dokka/styles/style.css: Language not supported
- dokka-subprojects/plugin-base/src/main/resources/dokka/ui-kit/ui-kit.css: Language not supported
- dokka-subprojects/plugin-base/src/main/resources/dokka/ui-kit/ui-kit.min.css: Language not supported
nikpachoo
approved these changes
May 5, 2025
| } | ||
|
|
||
| th { | ||
| padding: 7.5px 15.5px; |
There was a problem hiding this comment.
Could you please double check the float values? Didn't expect to have it there.
nikpachoo
approved these changes
May 5, 2025
* feat: restyled tabs and made them accessible * fix: removed tabs underline when they wrap * feat: clear toc state by click on the logo and by closing a tab (#4093)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how it looks like
