Fix some Javadoc links with generic parameters #4159
Conversation
7f017f1 to
3e2d889
Compare
3e2d889 to
a23455d
Compare
|
Notice According to the specification , Javadoc links can have type parameters,
In Dokka, rendered links and labels have no type parameters at all. |
Is there a reason not to do it in K2? I mean, if we don't register it, we may throw NPE in some cases when parsing Javadoc. But if we register it, as far as I understand, we will just receive some empty results instead of NPE. Or maybe I'm wrong, and with the changes in this PR, we will not fall back to using |
I mean this, at least in the current case. However, I do know why it was registered in K1. It just seems unnecessary. |
| valueElement ?: dataElements.firstOrNull { it !is PsiWhiteSpace } | ||
| dataElements.firstOrNull { | ||
| it.node.elementType == JavaDocElementType.DOC_REFERENCE_HOLDER || | ||
| it.node.elementType == JavaDocElementType.DOC_METHOD_OR_FIELD_REF |
There was a problem hiding this comment.
Could you please add a comment on why those two specific types should be used here?
It's not really clear for me why only those two out of all JavaDocElementTypes we should care about
In K1, we register IDE's service
JavadocManager, we could do the same in K2:registerProjectService(JavadocManager::class.java, JavadocManagerImpl(project))However, it seems unnecessary, since the link is unresolved in K1 as well.