Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@whyoleg
Copy link
Collaborator

@whyoleg whyoleg commented Aug 6, 2025

Additionally, align cache redirector usages to be similar to kotlin.git usages

Additionally align cache redirector usages to be similar to kotlin.git usages
@whyoleg whyoleg requested a review from adam-enko August 6, 2025 16:24
maven("https://cache-redirector.jetbrains.com/repo.maven.apache.org/maven2") {
name = "MavenCentral-JBCache"
}
mavenCentral { setUrl("https://cache-redirector.jetbrains.com/maven-central") }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we keep the repository name? If there are problems with the repo Gradle prints a nicer error message which helps track down the cause.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I can get them back. TBH, I've never seen those names appear anywhere, and kotlin.git doesn't provide them too :)
E.g., if the dependency can't be resolved, it will still just print the URL:

A problem occurred configuring project ':dokka-gradle-plugin'.
> Could not resolve all dependencies for configuration 'classpath'.
   > Could not find com.example.xxx:xxx:1.
     Searched in the following locations:
       - https://cache-redirector.jetbrains.com/maven-central/com/example/xxx/xxx/1/xxx-1.pom
       - https://cache-redirector.jetbrains.com/plugins.gradle.org/m2/com/example/xxx/xxx/1/xxx-1.pom
     Required by:
         project :dokka-gradle-plugin > project :build-logic

Copy link
Member

@adam-enko adam-enko Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, you're right. It's not shown in the console output. I was thinking of the build scan report

image

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks! Now I see how that might be useful
For this PR, it shows like this:
Image

I will then bring those names back, just for consistency, so that we know that we cache-redirector everywhere.
As well as update the name of Node/Yarn repositories to not include the URL, as it's redundant there

Thanks for the explanation!

@whyoleg whyoleg requested a review from adam-enko August 7, 2025 13:16
…e now published to `https://cache-redirector.jetbrains.com/intellij-dependencies`, which is the original repository behind `https://cache-redirector.jetbrains.com/intellij-third-party-dependencies` redirect

`kotlin-ide` is not used anymore, because we don't depend on kotlin idea plugin, but just copied their code
@whyoleg whyoleg merged commit b0bdb06 into master Aug 12, 2025
14 checks passed
@whyoleg whyoleg deleted the whyoleg/redirector branch August 12, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants