-
Notifications
You must be signed in to change notification settings - Fork 461
Migrate to redirector.kotlinlang.org
#4188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Additionally align cache redirector usages to be similar to kotlin.git usages
build-logic/settings.gradle.kts
Outdated
| maven("https://cache-redirector.jetbrains.com/repo.maven.apache.org/maven2") { | ||
| name = "MavenCentral-JBCache" | ||
| } | ||
| mavenCentral { setUrl("https://cache-redirector.jetbrains.com/maven-central") } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we keep the repository name? If there are problems with the repo Gradle prints a nicer error message which helps track down the cause.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can get them back. TBH, I've never seen those names appear anywhere, and kotlin.git doesn't provide them too :)
E.g., if the dependency can't be resolved, it will still just print the URL:
A problem occurred configuring project ':dokka-gradle-plugin'.
> Could not resolve all dependencies for configuration 'classpath'.
> Could not find com.example.xxx:xxx:1.
Searched in the following locations:
- https://cache-redirector.jetbrains.com/maven-central/com/example/xxx/xxx/1/xxx-1.pom
- https://cache-redirector.jetbrains.com/plugins.gradle.org/m2/com/example/xxx/xxx/1/xxx-1.pom
Required by:
project :dokka-gradle-plugin > project :build-logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks! Now I see how that might be useful
For this PR, it shows like this:
I will then bring those names back, just for consistency, so that we know that we cache-redirector everywhere.
As well as update the name of Node/Yarn repositories to not include the URL, as it's redundant there
Thanks for the explanation!
…e now published to `https://cache-redirector.jetbrains.com/intellij-dependencies`, which is the original repository behind `https://cache-redirector.jetbrains.com/intellij-third-party-dependencies` redirect `kotlin-ide` is not used anymore, because we don't depend on kotlin idea plugin, but just copied their code
Additionally, align cache redirector usages to be similar to kotlin.git usages