Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make GC more aggressive in integration tests #4244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 4, 2025
Merged

Make GC more aggressive in integration tests #4244

merged 3 commits into from
Sep 4, 2025

Conversation

@vmishenev
Copy link
Contributor

No description provided.

@vmishenev vmishenev changed the title Make more aggressive GC in BasicGradleIntegrationTest Make GC more aggressive in BasicGradleIntegrationTest Sep 3, 2025
@vmishenev vmishenev mentioned this pull request Sep 3, 2025
Merged
@vmishenev vmishenev requested a review from whyoleg September 4, 2025 09:40
@vmishenev vmishenev marked this pull request as ready for review September 4, 2025 09:40
whyoleg
whyoleg approved these changes Sep 4, 2025
View reviewed changes
Copy link
Collaborator

@whyoleg whyoleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think, maybe it makes sense to just set "-XX:SoftRefLRUPolicyMSPerMB=10" as default arguments in tests?

@vmishenev vmishenev requested a review from whyoleg September 4, 2025 11:52
whyoleg
whyoleg approved these changes Sep 4, 2025
View reviewed changes
Copy link
Collaborator

@whyoleg whyoleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to go, comments are mostly about some cleanup which could be done

...-tests/gradle/src/main/kotlin/org/jetbrains/dokka/it/gradle/AbstractGradleIntegrationTest.kt Outdated
vararg arguments: String,
jvmArgs: List<String> = listOf("-Xmx2G", "-XX:MaxMetaspaceSize=1G"),
jvmArgs: List<String> = listOf("-Xmx2G", "-XX:MaxMetaspaceSize=800m",
"-XX:SoftRefLRUPolicyMSPerMB=10" // to free up the metaspace on JVM 8, see https://youtrack.jetbrains.com/issue/KT-55831/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, I was thinking about just providing this argument explicitly to withJvmArguments function call below in addition to jvmArgs, so that we don't need to repeat it, if we need to override other jvmArgs for test
WDYT?

...a-integration-tests/gradle/src/testTemplateProjectBasic/kotlin/BasicGradleIntegrationTest.kt Outdated
"dokkaJavadoc",
"dokkaGfm",
"dokkaJekyll",
jvmArgs = listOf(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it be removed? And in all other places?

@vmishenev vmishenev force-pushed the vmishenev/Make-more-aggressive-GC-in-BasicGradleIntegrationTest branch 3 times, most recently from a66dfe0 to 618d22d Compare September 4, 2025 13:24
@vmishenev vmishenev force-pushed the vmishenev/Make-more-aggressive-GC-in-BasicGradleIntegrationTest branch from 618d22d to b524276 Compare September 4, 2025 13:24
@vmishenev vmishenev changed the title Make GC more aggressive in BasicGradleIntegrationTest Make GC more aggressive in integration tests Sep 4, 2025
@vmishenev vmishenev merged commit ef58e02 into master Sep 4, 2025
14 checks passed
@vmishenev vmishenev deleted the vmishenev/Make-more-aggressive-GC-in-BasicGradleIntegrationTest branch September 4, 2025 20:35
@strangesource strangesource mentioned this pull request Sep 17, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@whyoleg whyoleg whyoleg approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vmishenev @whyoleg