-
Notifications
You must be signed in to change notification settings - Fork 134
Replace usage js with WasmJs in README.md #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some minor tweaks.
README.md
Outdated
|
|
||
| # DOM | ||
| You can build DOM tree with JVM and JS naturally | ||
| You can build a DOM tree with JVM, JS, and WASM naturally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing punctuation at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, what does naturally mean here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it should be like easy
README.md
Outdated
| You can build a DOM tree with JVM, JS, and WASM naturally | ||
|
|
||
| See example for JavaScript-targeted Kotlin | ||
| See example for WasmJs-targeted Kotlin: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rephrase: "The following example shows how to build the DOM for WasmJs-targeted Kotlin:"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, looks nice
README.md
Outdated
| # kotlinx.html | ||
|
|
||
| A kotlinx.html library provides DSL to build HTML to [Writer](https://docs.oracle.com/javase/8/docs/api/java/io/Writer.html)/[Appendable](https://docs.oracle.com/javase/8/docs/api/java/lang/Appendable.html) or DOM. Available to all Kotlin Multiplatform targets and browser(or other JavaScript engine) for better [Kotlin programming](https://kotlinlang.org) for Web. | ||
| A kotlinx.html library provides a DSL to build HTML to [Writer](https://docs.oracle.com/javase/8/docs/api/java/io/Writer.html)/[Appendable](https://docs.oracle.com/javase/8/docs/api/java/lang/Appendable.html) or DOM. Available to all Kotlin Multiplatform targets and browser(or other JavaScript engine) for better [Kotlin programming](https://kotlinlang.org) for Web. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it would be "The kotlinx.html library...".
Also browsers and engines in plural.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, fixed
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [org.postgresql:postgresql](https://jdbc.postgresql.org) ([source](https://github.com/pgjdbc/pgjdbc)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `42.7.4` -> `42.7.5` | | [org.jetbrains.kotlinx:kotlinx-html-jvm](https://github.com/Kotlin/kotlinx.html) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `0.11.0` -> `0.12.0` | | [org.jooq:jooq](http://www.jooq.org) ([source](https://github.com/jOOQ/jOOQ)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `3.18.24` -> `3.18.25` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.45.0` -> `1.45.1` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.45.0` -> `1.45.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.51` -> `2.29.52` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.51` -> `2.29.52` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.51` -> `2.29.52` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.51` -> `2.29.52` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.51` -> `2.29.52` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.51` -> `2.29.52` | --- ### Release Notes <details> <summary>Kotlin/kotlinx.html (org.jetbrains.kotlinx:kotlinx-html-jvm)</summary> ### [`v0.12.0`](https://github.com/Kotlin/kotlinx.html/releases/tag/0.12.0) #### What's Changed - Added HTML templates by [@​e5l](https://github.com/e5l) in Kotlin/kotlinx.html#255 - Replace usage js with WasmJs in README.md by [@​e5l](https://github.com/e5l) in Kotlin/kotlinx.html#257 - Improve Gradle build logic by [@​hfhbd](https://github.com/hfhbd) in Kotlin/kotlinx.html#258 - Use kotlin.test everywhere by [@​hfhbd](https://github.com/hfhbd) in Kotlin/kotlinx.html#259 - Replace custom time handling with kotlin.time.TimeSource by [@​hfhbd](https://github.com/hfhbd) in Kotlin/kotlinx.html#260 - Add contracts to node append and tag declaration calls by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#264 - Added "as" attribute for Link tag by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#265 - Added IE-specific values for textarea wrap attribute by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#266 - Reducing the amount of compiler warnings in gen-enums.kt by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#269 - Added "referrerpolicy", "media", and "download" attributes for "a" tag by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#270 - Fixing typo in area attribute by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#271 - Updating Github Actions and enabling cross-platform testing by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#272 - Improving Tag Generation by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#274 - Added srcset attribute to "source" tag by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#273 - Added "auto" value for "dir" attribute by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#275 - Upgrading Kotlin to 2.0.0 by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#282 - Reworked the validation of attribute names to better correspond to HTML standards by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#276 - Make attribute traits inheritable by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#280 - Using correct string type for input attribute "autocomplete" by [@​severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#278 - Support android native targets and wasm-wasi by [@​whyoleg](https://github.com/whyoleg) in Kotlin/kotlinx.html#288 #### New Contributors - [@​hfhbd](https://github.com/hfhbd) made their first contribution in Kotlin/kotlinx.html#258 - [@​whyoleg](https://github.com/whyoleg) made their first contribution in Kotlin/kotlinx.html#288 **Full Changelog**: Kotlin/kotlinx.html@0.11.0...0.12.0 </details> --- ### Configuration π **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). π¦ **Automerge**: Disabled by config. Please merge this manually once you are satisfied. β» **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. π» **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 3e633633f6599555fd8c75c49d915b16242cac27
Fix #256