Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@e5l
Copy link
Member

@e5l e5l commented Feb 6, 2024

Fix #256

@e5l e5l self-assigned this Feb 6, 2024
Copy link

@vnikolova vnikolova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor tweaks.

README.md Outdated

# DOM
You can build DOM tree with JVM and JS naturally
You can build a DOM tree with JVM, JS, and WASM naturally

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing punctuation at the end.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, what does naturally mean here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it should be like easy

README.md Outdated
You can build a DOM tree with JVM, JS, and WASM naturally

See example for JavaScript-targeted Kotlin
See example for WasmJs-targeted Kotlin:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrase: "The following example shows how to build the DOM for WasmJs-targeted Kotlin:"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks nice

README.md Outdated
# kotlinx.html

A kotlinx.html library provides DSL to build HTML to [Writer](https://docs.oracle.com/javase/8/docs/api/java/io/Writer.html)/[Appendable](https://docs.oracle.com/javase/8/docs/api/java/lang/Appendable.html) or DOM. Available to all Kotlin Multiplatform targets and browser(or other JavaScript engine) for better [Kotlin programming](https://kotlinlang.org) for Web.
A kotlinx.html library provides a DSL to build HTML to [Writer](https://docs.oracle.com/javase/8/docs/api/java/io/Writer.html)/[Appendable](https://docs.oracle.com/javase/8/docs/api/java/lang/Appendable.html) or DOM. Available to all Kotlin Multiplatform targets and browser(or other JavaScript engine) for better [Kotlin programming](https://kotlinlang.org) for Web.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it would be "The kotlinx.html library...".
Also browsers and engines in plural.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed

@e5l e5l force-pushed the e5l/readme-wasm branch from f73f0bd to 10f91eb Compare February 6, 2024 16:38
@e5l e5l merged commit 6c926dd into master Feb 6, 2024
@e5l e5l deleted the e5l/readme-wasm branch February 6, 2024 16:39
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull request Jan 15, 2025
| Package | Type | Package file | Manager | Update | Change |
|---|---|---|---|---|---|
| [org.postgresql:postgresql](https://jdbc.postgresql.org)
([source](https://github.com/pgjdbc/pgjdbc)) | dependencies |
misk/gradle/libs.versions.toml | gradle | patch | `42.7.4` -> `42.7.5` |
|
[org.jetbrains.kotlinx:kotlinx-html-jvm](https://github.com/Kotlin/kotlinx.html)
| dependencies | misk/gradle/libs.versions.toml | gradle | minor |
`0.11.0` -> `0.12.0` |
| [org.jooq:jooq](http://www.jooq.org)
([source](https://github.com/jOOQ/jOOQ)) | dependencies |
misk/gradle/libs.versions.toml | gradle | patch | `3.18.24` -> `3.18.25`
|
| [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`1.45.0` -> `1.45.1` |
| [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`1.45.0` -> `1.45.1` |
| [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.51` -> `2.29.52` |
|
[software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava)
| dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.51` -> `2.29.52` |
| [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.51` -> `2.29.52` |
| [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.51` -> `2.29.52` |
| [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.51` -> `2.29.52` |
| [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) |
dependencies | misk/gradle/libs.versions.toml | gradle | patch |
`2.29.51` -> `2.29.52` |

---

### Release Notes

<details>
<summary>Kotlin/kotlinx.html
(org.jetbrains.kotlinx:kotlinx-html-jvm)</summary>

###
[`v0.12.0`](https://github.com/Kotlin/kotlinx.html/releases/tag/0.12.0)

#### What's Changed

- Added HTML templates by [@&#8203;e5l](https://github.com/e5l) in
Kotlin/kotlinx.html#255
- Replace usage js with WasmJs in README.md by
[@&#8203;e5l](https://github.com/e5l) in
Kotlin/kotlinx.html#257
- Improve Gradle build logic by
[@&#8203;hfhbd](https://github.com/hfhbd) in
Kotlin/kotlinx.html#258
- Use kotlin.test everywhere by
[@&#8203;hfhbd](https://github.com/hfhbd) in
Kotlin/kotlinx.html#259
- Replace custom time handling with kotlin.time.TimeSource by
[@&#8203;hfhbd](https://github.com/hfhbd) in
Kotlin/kotlinx.html#260
- Add contracts to node append and tag declaration calls by
[@&#8203;severn-everett](https://github.com/severn-everett) in
Kotlin/kotlinx.html#264
- Added "as" attribute for Link tag by
[@&#8203;severn-everett](https://github.com/severn-everett) in
Kotlin/kotlinx.html#265
- Added IE-specific values for textarea wrap attribute by
[@&#8203;severn-everett](https://github.com/severn-everett) in
Kotlin/kotlinx.html#266
- Reducing the amount of compiler warnings in gen-enums.kt by
[@&#8203;severn-everett](https://github.com/severn-everett) in
Kotlin/kotlinx.html#269
- Added "referrerpolicy", "media", and "download" attributes for "a" tag
by [@&#8203;severn-everett](https://github.com/severn-everett) in
Kotlin/kotlinx.html#270
- Fixing typo in area attribute by
[@&#8203;severn-everett](https://github.com/severn-everett) in
Kotlin/kotlinx.html#271
- Updating Github Actions and enabling cross-platform testing by
[@&#8203;severn-everett](https://github.com/severn-everett) in
Kotlin/kotlinx.html#272
- Improving Tag Generation by
[@&#8203;severn-everett](https://github.com/severn-everett) in
Kotlin/kotlinx.html#274
- Added srcset attribute to "source" tag by
[@&#8203;severn-everett](https://github.com/severn-everett) in
Kotlin/kotlinx.html#273
- Added "auto" value for "dir" attribute by
[@&#8203;severn-everett](https://github.com/severn-everett) in
Kotlin/kotlinx.html#275
- Upgrading Kotlin to 2.0.0 by
[@&#8203;severn-everett](https://github.com/severn-everett) in
Kotlin/kotlinx.html#282
- Reworked the validation of attribute names to better correspond to
HTML standards by
[@&#8203;severn-everett](https://github.com/severn-everett) in
Kotlin/kotlinx.html#276
- Make attribute traits inheritable by
[@&#8203;severn-everett](https://github.com/severn-everett) in
Kotlin/kotlinx.html#280
- Using correct string type for input attribute "autocomplete" by
[@&#8203;severn-everett](https://github.com/severn-everett) in
Kotlin/kotlinx.html#278
- Support android native targets and wasm-wasi by
[@&#8203;whyoleg](https://github.com/whyoleg) in
Kotlin/kotlinx.html#288

#### New Contributors

- [@&#8203;hfhbd](https://github.com/hfhbd) made their first
contribution in Kotlin/kotlinx.html#258
- [@&#8203;whyoleg](https://github.com/whyoleg) made their first
contribution in Kotlin/kotlinx.html#288

**Full Changelog**:
Kotlin/kotlinx.html@0.11.0...0.12.0

</details>

---

### Configuration

πŸ“… **Schedule**: Branch creation - "after 6pm every weekday,before 2am
every weekday" in timezone Australia/Melbourne, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

β™» **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

πŸ‘» **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://github.com/renovatebot/renovate).

GitOrigin-RevId: 3e633633f6599555fd8c75c49d915b16242cac27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust readme file to replace kotlin-js with wasm

2 participants