Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: nanoGPT implementation using Reactant #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

feat: nanoGPT implementation using Reactant #1062

wants to merge 10 commits into from

Conversation

@avik-pal
Copy link
Member

@avik-pal avik-pal commented Nov 9, 2024 •
edited
Loading

Needs

error: could not compute the adjoint for this operation %51 = "stablehlo.dynamic_gather"(%15, %0, %12) <{dimension_numbers = #stablehlo.gather<offset_dims = [0], collapsed_slice_dims = [1], start_index_map = [1], index_vector_dim = 1>}> : (tensor<64x64xf32>, tensor<64xi64>, tensor<2xi64>) -> tensor<64x64xf32>
error: could not compute the adjoint for this operation %47 = "stablehlo.dynamic_gather"(%14, %46, %12) <{dimension_numbers = #stablehlo.gather<offset_dims = [0], collapsed_slice_dims = [1], start_index_map = [1], index_vector_dim = 1>}> : (tensor<64x67xf32>, tensor<8192xi64>, tensor<2xi64>) -> tensor<64x8192xf32>
ERROR: LoadError: "failed to run pass manager on module"

@avik-pal avik-pal marked this pull request as draft November 9, 2024 02:19
@avik-pal avik-pal force-pushed the ap/nanogpt_reactant branch 4 times, most recently from 844a274 to d2e7299 Compare November 15, 2024 02:58
@avik-pal avik-pal force-pushed the ap/nanogpt_reactant branch 2 times, most recently from f4504bc to 9b97721 Compare November 16, 2024 18:53
Vaibhavdixit02
Vaibhavdixit02 reviewed Dec 7, 2024
View reviewed changes
@avik-pal avik-pal requested a review from Copilot December 11, 2024 14:23
Copilot AI reviewed Dec 11, 2024
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no suggestions.

Files not reviewed (1)
  • examples/NanoGPT/main.jl: Language not supported

@avik-pal avik-pal force-pushed the ap/nanogpt_reactant branch from 9b97721 to 6359fdb Compare February 7, 2025 21:43
@avik-pal avik-pal force-pushed the ap/nanogpt_reactant branch from 386963b to 2dc6742 Compare May 23, 2025 00:08
github-actions[bot]
github-actions bot reviewed May 23, 2025
View reviewed changes
@avik-pal avik-pal force-pushed the ap/nanogpt_reactant branch from 24e71cd to 0103f95 Compare May 23, 2025 21:34
@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2025 •
edited
Loading

Benchmark Results (ASV)

main b508bb4... main / b508bb4...
basics/overhead 0.135 ± 0.0013 μs 0.13 ± 0.0023 μs 1.04 ± 0.021
time_to_load 0.873 ± 0.0064 s 0.878 ± 0.0081 s 0.994 ± 0.012

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@avik-pal avik-pal force-pushed the ap/nanogpt_reactant branch from b508bb4 to f64885f Compare May 30, 2025 04:10
@avik-pal avik-pal force-pushed the ap/nanogpt_reactant branch 2 times, most recently from f9cd522 to 1d6fe91 Compare September 3, 2025 03:13
@avik-pal avik-pal force-pushed the ap/nanogpt_reactant branch from 1d6fe91 to fdd23e2 Compare November 1, 2025 14:56
@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.64%. Comparing base (a2167f2) to head (b508bb4).

⚠️ Current head b508bb4 differs from pull request most recent head fdd23e2

Please upload reports for the commit fdd23e2 to get more accurate results.

❗ There is a different number of reports uploaded between BASE (a2167f2) and HEAD (b508bb4). Click for more details.

HEAD has 31 uploads less than BASE
Flag BASE (a2167f2) HEAD (b508bb4)
51 20
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1062       +/-   ##
===========================================
- Coverage   82.53%   67.64%   -14.89%     
===========================================
  Files         168      154       -14     
  Lines        6957     6408      -549     
===========================================
- Hits         5742     4335     -1407     
- Misses       1215     2073      +858

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@Vaibhavdixit02 Vaibhavdixit02 Vaibhavdixit02 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

reactant

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@avik-pal @Vaibhavdixit02