Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Oct 31, 2025. It is now read-only.

prioritize fractional scale events #439

Merged
LGFae merged 1 commit into from
Jun 6, 2025
Merged

prioritize fractional scale events #439

LGFae merged 1 commit into from
Jun 6, 2025

Conversation

@LGFae
Copy link
Owner

@LGFae LGFae commented Jun 6, 2025

We currently let preferred_buffer_scale events overwrite the values we received from the fractional scale protocol. This is incorrect. Wayland is an entirely assynchronous protocol, so we should prioritize the more precise events over the more generic ones.

@LGFae
prioritize fractional scale events
8b3b425 
We currently let preferred_buffer_scale events overwrite the values we
received from the fractional scale protocol. This is incorrect. Wayland
is an entirely assynchronous protocol, so we should prioritize the more
precise events over the more generic ones.
@LGFae LGFae linked an issue Jun 6, 2025 that may be closed by this pull request
Doesn't work with display scaling #438
Closed
@LGFae LGFae mentioned this pull request Jun 6, 2025
Closed
@LGFae LGFae linked an issue Jun 6, 2025 that may be closed by this pull request
Regression in new version - incorrect wallpaper scaling #433
Closed
This was referenced Jun 6, 2025
Closed
Closed
@LGFae LGFae linked an issue Jun 6, 2025 that may be closed by this pull request
crash when changing wallpaper #437
Closed
This was referenced Jun 6, 2025
Closed
Closed
@LGFae LGFae marked this pull request as ready for review June 6, 2025 13:58
@LOSEARDES77
Copy link

LOSEARDES77 commented Jun 6, 2025

I have been bisecting this and found this as the first bad commit 56928f7

@LGFae
Copy link
Owner Author

LGFae commented Jun 6, 2025

bad commit... for which issue? Note someone has already pointed at that commit in issue #386, which should also be fixed by this PR.

@LOSEARDES77
Copy link

LOSEARDES77 commented Jun 6, 2025

Ho sorry i got confused i thought this was for the incorrect scaling issue

@LOSEARDES77
Copy link

LOSEARDES77 commented Jun 6, 2025

This pr solved the fractional scaling issue. I just tested

@LGFae LGFae mentioned this pull request Jun 6, 2025
Open
@LOSEARDES77
Copy link

LOSEARDES77 commented Jun 6, 2025

I am still getting an error but that was happening before too and everything works as intended

         0ms [INFO]  selected pixel format: Xbgr
       110ms [INFO]  BumpPool with: 1 buffers. Size: 16000Kb
       152ms [ERROR] We failed to find wayland buffer with id: 11. This should be impossible.
       152ms [ERROR] We failed to find wayland buffer with id: 11. This should be impossible.
       270ms [INFO]  BumpPool with: 1 buffers. Size: 16000Kb
       310ms [ERROR] We failed to find wayland buffer with id: 8. This should be impossible.

@LGFae
Copy link
Owner Author

LGFae commented Jun 6, 2025

Yeah, that's unrelated.

@LGFae LGFae merged commit f9ace9d into main Jun 6, 2025
9 checks passed
@LGFae LGFae deleted the prioritize-fractional-scale branch June 6, 2025 15:14
This was referenced Jun 6, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@Lstpr4
Copy link

Lstpr4 commented Jun 6, 2025

Can you give me help on how to fix the issue?

@LGFae
Copy link
Owner Author

LGFae commented Jun 6, 2025

As this was already released, you would need to wait until your distro releases the latest swww version (0.10.2), or simply clone this repository and try installing it manually yourself. I cannot comment on how do that as it is specific to every distro.

This was referenced Jun 7, 2025
Closed
Closed
@kRHYME7 kRHYME7 mentioned this pull request Jun 7, 2025
Closed
@JaKooLit JaKooLit mentioned this pull request Jun 7, 2025
Closed
1 task
@everyoneexe
Copy link

everyoneexe commented Jun 9, 2025

Fix Applied
File: client/src/imgproc.rs
Line: 452

Removed .fit_into_destination(Some((0.5, 0.5))) — took a different route than you folks, only to realize you patched it more elegantly later on 😅
Anyway, bug's gone. Different scalpel, same surgery.

@SegmentationViolator SegmentationViolator mentioned this pull request Jun 25, 2025
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Doesn't work with display scaling crash when changing wallpaper Regression in new version - incorrect wallpaper scaling

5 participants

@LGFae @LOSEARDES77 @Lstpr4 @everyoneexe