cpp 17: policy/openmp/params/forall.hpp simplifications #1925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adayton1
reviewed
Oct 2, 2025
|
|
||
| #pragma omp for schedule(guided) reduction(combine : f_params) | ||
| for (decltype(distance_it) i = 0; i < distance_it; ++i) | ||
| if constexpr (ChunkSize <= 0) |
There was a problem hiding this comment.
Can you pick a consistent ordering? In some forall implementations, you do the ChunkSize > 0 case first and in others the ChunkSize <= 0 first.
There was a problem hiding this comment.
yes, good point. I will do that
adayton1
approved these changes
Oct 2, 2025
|
@johnbowen42 , not sure if this might be out of the scope of this PR. But there may also be a lot of duplicate capability here: https://github.com/LLNL/RAJA/blob/develop/include/RAJA/policy/openmp/forall.hpp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the ChunkSize overloads inside policy/openmp/params/forall.hpp with if constexpr