Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adding modest extensions to experiement with GPUs #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 91 commits into from
Oct 16, 2025
Merged

Adding modest extensions to experiement with GPUs #350

merged 91 commits into from
Oct 16, 2025

Conversation

@jmikeowen
Copy link
Collaborator

@jmikeowen jmikeowen commented Jun 5, 2025 •
edited
Loading

Summary

  • This PR is a feature
  • It does the following:
    • Adds extensions to create views of classes we need to use on the GPU.
    • These are intended to be a minimal set of extensions that do not change the structure of Spheral too much, simply augmenting where necessary.
    • Only targeting unified memory architectures for now.

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#)
  • LLNLSpheral PR has passed all tests.

@jmikeowen jmikeowen self-assigned this Jun 5, 2025
@mdavis36 mdavis36 changed the base branch from develop to bugfix/int_to_size_t June 18, 2025 16:41
@ldowen ldowen changed the base branch from bugfix/int_to_size_t to develop June 18, 2025 17:49
@ldowen ldowen changed the base branch from develop to bugfix/int_to_size_t June 18, 2025 17:50
@mdavis36 mdavis36 changed the base branch from bugfix/int_to_size_t to develop June 18, 2025 17:57
@ldowen ldowen mentioned this pull request Jun 20, 2025
Merged
3 tasks
jmikeowen added 24 commits June 24, 2025 16:18
@jmikeowen
Merge branch 'develop' into feature/GPU_minimal
a0fbf5c
@jmikeowen
Starting work to allow us to use std::span or boost::span
b2dcdbb
@jmikeowen
Fixed macros for detecting if std::span is available
375793c
@jmikeowen
More fixes for detecting std::span
7920bad
@jmikeowen
Might have our boost::span fallback working
9aef151
@jmikeowen
Merge branch 'develop' into feature/GPU_minimal
858a5ab
@jmikeowen
Putting us back on C++20 for now to use std::span
4fbb802
@jmikeowen
toView -> view
eb2b2fa
@jmikeowen
Restoring the axom patch for C++20 that somehow got purged by merging
ebfdc5a 
with develop
@jmikeowen
Initial merge with develop compiling
4cafddf
@jmikeowen
Avoiding building C++ tests of FieldView and FieldListView when
3add1db 
building with SPHERAL_UNIFIED_MEMORY (for now)
@jmikeowen
Finally back to building and running most tests on rzadams. A couple
1d66bad 
of tests failing.
@jmikeowen
Fixing missing std:: namespace
2b07253
@jmikeowen
Going back to C++ 17 -- it appears boost::span works on rzadams
79d69db
@jmikeowen
More missing std:: namespace declarations
dc6dfc4
@jmikeowen
Didn't need to screen out the standard Field CPP test
3f51c89
@jmikeowen
Initial renaming of our FieldSpan/FieldSpanList ->
4c49295 
FieldView/FieldListView for consistency with Mike and Landon's work
@jmikeowen
Adding unit test
372b7f2
@jmikeowen
Protecting from div by 0 NANs
e979510
@jmikeowen
Merge branch 'develop' into feature/GPU_minimal
60e4e8b
@jmikeowen
Building with ManagagedArray in place of span, but failing tests
a7dd126
@jmikeowen
Bugfix
2453f42
@jmikeowen
Checkpoint merging span and ManagedArray stuff in Field
3488958
@jmikeowen
Bugfixes for copy constructor -- can't allow default copy operations
0bd04bb 
of span or ManagedArray
jmikeowen added 23 commits October 8, 2025 14:36
@jmikeowen
Merge branch 'develop' into feature/GPU_minimal
6fe8dc2
@jmikeowen
Compilation fixes
431c13c
@jmikeowen
Working on use of ManagedArray in Field/FieldList
309f70a
@jmikeowen
Minor reformatting
99ad090
@jmikeowen
Gotta be careful of allocating zero size ManagedArrays
5e2f769
@jmikeowen
ManagedArray::size is a lie
572f8bb
@jmikeowen
Minor modernization
caad647
@jmikeowen
More modernizatino
38815e7
@jmikeowen
Fixes for computing work
32f4498
@jmikeowen
Being a bit more careful about range based loops with MA
1c2da38
@jmikeowen
Merge branch 'develop' into feature/GPU_minimal
cdaa445
@jmikeowen
CONTRACT_VAR for non-DBC builds
a170849
@jmikeowen
Fixed the problem with ManagedArray sizes sometimes not matching what
4b6262e 
we expect
@jmikeowen
Bugfixes
21ef246
@jmikeowen
Accidentally checked in commenting out of a test
21c1d32
@jmikeowen
Now building with SPHERAL_UNIFIED_MEMORY true or false
a14eec1
@jmikeowen
Moved all CHAI callback nonsense back to value classes -- having that
f0b0111 
in the view caused my hangs going to device
@jmikeowen
FieldListView GPU tests passing with ManagedArray
6b1d5d2
@jmikeowen
A few more unit tests
b073f2a
@jmikeowen
Defaulting SPHERAL_UNIFIED_MEMORY to OFF
4ddab44
@jmikeowen
Explicitly forwarding inline math methods from view class. This
ba2cea8 
shouldn't be necessary (and C++ uses seem to work just fine without
this), but cleaned up some Python issues using Field /=
@jmikeowen
[skip-ci] Updating RELEASE_NOTES
442aa55
@jmikeowen
Comment change
c0c7adc
@jmikeowen jmikeowen marked this pull request as ready for review October 15, 2025 16:50
@jmikeowen jmikeowen requested a review from ldowen October 15, 2025 16:50
ldowen
ldowen reviewed Oct 15, 2025
View reviewed changes
tests/cpp/Field/fieldlistview_tests.cc
DEBUG_LOG << "Start Kernel 1";
RAJA::forall<TypeParam>(TRS_UINT(0, numFields),
[=] SPHERAL_HOST_DEVICE (size_t i) {
SPHERAL_ASSERT_EQ(fl_v.size(), numFields);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should decide what sort of spacing we want for these RAJA loops.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, in this case this was what happened automatically with emacs formatting. That opening parenthesis pushes it way to the right.

ldowen
ldowen approved these changes Oct 16, 2025
View reviewed changes
Copy link
Collaborator

@ldowen ldowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmikeowen jmikeowen merged commit ae52d84 into develop Oct 16, 2025
2 checks passed
@jmikeowen jmikeowen deleted the feature/GPU_minimal branch October 29, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldowen ldowen ldowen approved these changes

Assignees

@jmikeowen jmikeowen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmikeowen @ldowen