Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove DEBUG compile def #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2025
Merged

Remove DEBUG compile def #420

merged 1 commit into from
Oct 24, 2025

Conversation

@ldowen
Copy link
Collaborator

@ldowen ldowen commented Oct 24, 2025 •
edited
Loading

Summary

  • This PR is a bugfix for CMake variable overhaul #413
  • It does the following:
    • Removes the DEBUG compile flag.
    • Replaces debug print statements in HDF5IO.cc with DEBUG_LOG calls.
    • Removes logic to clean up INTERFACE_COMPILE_OPTIONS since this breaks sometimes.

ToDo :

  • Annotate RELEASE_NOTES.md with notable changes.
  • Create LLNLSpheral PR pointing at this branch. (PR#176)
  • LLNLSpheral PR has passed all tests.

@ldowen
Replace DEBUG compile def with DEBUG_LOG in code, removed DEBUG flag,…
26d7ed7 
… removed logic to clean up export targets since it can cause issues for other codes using Spheral
@ldowen ldowen requested review from jmikeowen and ptsuji October 24, 2025 20:31
@ldowen ldowen self-assigned this Oct 24, 2025
@ldowen ldowen merged commit da9e5be into develop Oct 24, 2025
1 check passed
@ldowen ldowen deleted the bugfix/rename_debug_def branch October 24, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmikeowen jmikeowen jmikeowen approved these changes

@ptsuji ptsuji ptsuji approved these changes

Assignees

@ldowen ldowen

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ldowen @jmikeowen @ptsuji