Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Rename AudioPort -> AudioBusHandle#7712

Merged
JohannesLorenz merged 5 commits intoLMMS:masterfrom
JohannesLorenz:audioport-rename
Feb 28, 2025
Merged

Rename AudioPort -> AudioBusHandle#7712
JohannesLorenz merged 5 commits intoLMMS:masterfrom
JohannesLorenz:audioport-rename

Conversation

@JohannesLorenz
Copy link
Contributor

No functional changes.

No functional changes.
@JohannesLorenz JohannesLorenz marked this pull request as ready for review February 15, 2025 20:00
Copy link
Contributor

@sakertooth sakertooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In regards to the name change, I am okay with it. @messmerd might have something to say about this, but I am okay with AudioBusHandle, as I don't think its particularly efficient to ponder about this for too long.

@messmerd
Copy link
Member

messmerd commented Feb 18, 2025

I'm rethinking whether "Handle" is a good term here.

Typically a "handle" is a pointer or integer identifier that is used to refer to some resource. This AudioPort on the other hand, is a ThreadableJob which processes an audio bus (and perhaps in the future, audio busses plural) rather than just a handle.

Some more applicable terms in my opinion would be "job" or "processor".

However, PlayHandle would also have the same issue of not technically being a handle. If this AudioBusHandle rename is for consistency with that, it may be okay for now.

@JohannesLorenz
Copy link
Contributor Author

That was what I was thinking. If we use Job here, we have to rename quite a lot of classes...

Copy link
Member

@messmerd messmerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohannesLorenz JohannesLorenz merged commit 3aa1a5d into LMMS:master Feb 28, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants