-
Notifications
You must be signed in to change notification settings - Fork 5
feat(propert): Ping the bootloader 3 times when getting a property #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the property retrieval functionality by adding retry logic for bootloader communication and improving argument handling for hex values.
- Adds retry mechanism to ping the bootloader up to 3 times before failing when getting a property
- Updates CLI argument parsing to support hex values using
int(x, 0)and removes type constraint - Improves error handling with null checks and better logging for ping attempts
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fd2bcb9 to
565bf23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
565bf23 to
1528658
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
1528658 to
042c0c6
Compare
Also changed it to use `int(x, 0)`, so hex values are supported
042c0c6 to
6e30df1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Also changed it to use
int(x, 0), so hex values are supported and made thepropertyargument non-optional