Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Lauszus
Copy link
Owner

@Lauszus Lauszus commented Sep 21, 2025

Also changed it to use int(x, 0), so hex values are supported and made the property argument non-optional

@Lauszus Lauszus added this to the 1.7.0 milestone Sep 21, 2025
@Lauszus Lauszus requested a review from Copilot September 21, 2025 16:15
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the property retrieval functionality by adding retry logic for bootloader communication and improving argument handling for hex values.

  • Adds retry mechanism to ping the bootloader up to 3 times before failing when getting a property
  • Updates CLI argument parsing to support hex values using int(x, 0) and removes type constraint
  • Improves error handling with null checks and better logging for ping attempts

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Lauszus Lauszus force-pushed the feature/get_property branch 2 times, most recently from fd2bcb9 to 565bf23 Compare September 21, 2025 16:19
@Lauszus Lauszus requested a review from Copilot September 21, 2025 16:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Lauszus Lauszus force-pushed the feature/get_property branch from 565bf23 to 1528658 Compare September 21, 2025 16:32
@Lauszus Lauszus requested a review from Copilot September 21, 2025 16:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Lauszus Lauszus force-pushed the feature/get_property branch from 1528658 to 042c0c6 Compare September 21, 2025 16:35
Also changed it to use `int(x, 0)`, so hex values are supported
@Lauszus Lauszus force-pushed the feature/get_property branch from 042c0c6 to 6e30df1 Compare September 21, 2025 16:36
@Lauszus Lauszus requested a review from Copilot September 21, 2025 16:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Lauszus Lauszus merged commit 888dd51 into main Sep 21, 2025
6 checks passed
@Lauszus Lauszus deleted the feature/get_property branch September 21, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants