feat: Added tests #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lauszus
commented
Sep 21, 2025
5b9ba7b to
c2f8081
Compare
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
ccd2a2d to
7f49546
Compare
8aae8ae to
e8275bf
Compare
e8275bf to
4995bff
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for the pyblhost library and makes some minor bug fixes. The tests cover all major classes (BlhostBase, BlhostCan, BlhostSerial, BlhostDataParser, BlhostCanListener) and their functionality including communication protocols, data parsing, error handling, and edge cases.
- Adds extensive test suite covering all major classes and their methods
- Fixes a type annotation bug in BlhostCan constructor parameter
- Adds test infrastructure with pytest, coverage reporting, and CI integration
Reviewed Changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_pyblhost.py | Comprehensive test suite covering all classes with 2328 lines of tests |
| src/pyblhost/pyblhost.py | Minor bug fixes: type annotation and ReliableUpdate logging placement |
| pyproject.toml | Adds pytest dependencies and coverage configuration |
| Makefile | Adds test targets and enhanced clean target |
| .github/workflows/build.yml | Integrates test execution and coverage reporting into CI |
| .github/workflows/coverage.yml | Adds coverage comment workflow for PR feedback |
| .github/copilot-instructions.md | Provides development workflow documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.