Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix healthcheck.js without ssl #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2023
Merged

Fix healthcheck.js without ssl #1384

merged 1 commit into from
Nov 14, 2023

Conversation

@stavros-k
Copy link
Contributor

@stavros-k stavros-k commented Nov 13, 2023 •
edited by pull-request-badge bot
Loading

stavros-k Quick stavros-k /patch-1 → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 0 Unchecked Tasks Powered by Pull Request Badge

Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category: Bugfix

Overview

Fixes the order of execution on port initialization
(similar to how SSL_PORT works currently) and also similar to how server.js picks the port

dashy/server.js

Line 39 in 50dc623

const port = process.env.PORT || (isDocker ? 80 : 4000);

Without this change, PORT is being ignored and port 80 is used

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@stavros-k stavros-k requested a review from Lissy93 as a code owner November 13, 2023 17:13
@vercel
Copy link

vercel bot commented Nov 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 5:14pm

@netlify
Copy link

netlify bot commented Nov 13, 2023 •
edited
Loading

✅ Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 2839821
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/6552594e95d2e3000900dc8e
😎 Deploy Preview https://deploy-preview-1384--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@viezly
Copy link

viezly bot commented Nov 13, 2023

Changes preview:

Legend:

👀 Review pull request on Viezly

Lissy93
Lissy93 approved these changes Nov 14, 2023
View reviewed changes
Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Lissy93 Lissy93 merged commit e511c2b into Lissy93:master Nov 14, 2023
@stavros-k stavros-k deleted the patch-1 branch November 14, 2023 20:34
@liss-bot
Copy link
Collaborator

liss-bot commented Mar 3, 2024

The fix for this issue has now been released in 2.1.2 ✨

If you haven't done so already, please update your instance to 2.1.2 or later. See 2.1.2 for full info.

Feel free to reach out if you need any more support. If you are enjoying Dashy, consider supporting the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lissy93 Lissy93 Lissy93 approved these changes

Assignees

No one assigned

Labels

🔨 Fixed 🛩️ Released 2.1.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stavros-k @liss-bot @Lissy93