Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@pedorich-n
Copy link
Contributor

@pedorich-n pedorich-n commented Sep 7, 2025

pedorich-n Quick pedorich-n /oidc-userinfo → Lissy93/dashy Commits: 1 | Files Changed: 1 | Additions: 1 Label Powered by Pull Request Badge

Category:
Bugfix

Overview
According to the OIDC ID Token spec, the ID token doesn't have to include any of the userinfo fields (username, email, groups, etc). They have to be requested separately from the userinfo endpoint. oidc-client-ts by default doesn't call that endpoint. So Dashy ends up with user: undefined {"groups":[],"roles":[]}.

To fix this, we simply need to pass loadUserInfo flag to OIDC's settings.
More detailed info: #1901 (comment)

Issue Number (if applicable) #1901

New Vars (if applicable)
N/A

Screenshot (if applicable)
N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • (If significant change) Bumps version in package.json

@pedorich-n pedorich-n requested a review from Lissy93 as a code owner September 7, 2025 04:43
@netlify
Copy link

netlify bot commented Sep 7, 2025

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 9ad6379
🔍 Latest deploy log https://app.netlify.com/projects/dashy-dev/deploys/68bd0d6e0eb1a40008352f51
😎 Deploy Preview https://deploy-preview-1914--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Lissy93 Lissy93 merged commit e70ade5 into Lissy93:master Sep 12, 2025
7 checks passed
@pedorich-n
Copy link
Contributor Author

Thanks!

@pedorich-n pedorich-n deleted the oidc-userinfo branch September 12, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants