fix: Load userInfo in OidcAuth #1914
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Bugfix
Overview
According to the OIDC ID Token spec, the ID token doesn't have to include any of the userinfo fields (username, email, groups, etc). They have to be requested separately from the
userinfoendpoint.oidc-client-tsby default doesn't call that endpoint. So Dashy ends up withuser: undefined {"groups":[],"roles":[]}.To fix this, we simply need to pass
loadUserInfoflag to OIDC's settings.More detailed info: #1901 (comment)
Issue Number (if applicable) #1901
New Vars (if applicable)
N/A
Screenshot (if applicable)
N/A
Code Quality Checklist (Please complete)