sd: clean up changes against stable-diffusion.cpp 90ef5f8 #1804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up the diff, and include a few missing changes, mainly from the upscaler and model weight type statistics.
|
Will take a look in a bit |
|
I could include the newer changes right now, but since master-334-d05e46c makes lots of small changes all over the place, I think it's best if we do this step-by-step. |
LostRuins
reviewed
Oct 23, 2025
| #include "tae.hpp" | ||
| #include "vae.hpp" | ||
|
|
||
| using std::isfinite; |
There was a problem hiding this comment.
i wonder why main sd.cpp doesnt need this but i think its ok to have
There was a problem hiding this comment.
I think it comes from C-style includes added by stb headers.
LostRuins
reviewed
Oct 23, 2025
LostRuins
approved these changes
Oct 23, 2025
|
all good now, merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the diff, and include a few missing changes, mainly from the upscaler and model weight type statistics.