-
-
Notifications
You must be signed in to change notification settings - Fork 517
CI, BLD: Use cibuildwheel to build and test Pyodide/WASM wheels for PyWavelets
#744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI, BLD: Use cibuildwheel to build and test Pyodide/WASM wheels for PyWavelets
#744
Conversation
b81e776 to
1e63b68
Compare
5ecb7fc to
b4f3a80
Compare
|
Wheel builds and tests are passing here (🎉): https://github.com/PyWavelets/pywt/actions/runs/9308866217/job/25623111691 There is one thing to be noted, though. Maybe this is a valid bug that we either need to raise upstream, or I did some invalid tinkering: none of the commands as follows: P.S. I was confused as to why the wheel gets retagged with the ABI tag |
Isn't that a matter of doing |
|
I thought so too, it's the usual |
2fe0471 to
e13d9c0
Compare
e13d9c0 to
6dd3ede
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. CI is green, CI log looks nice and everything seems to be in order there, and code is easier to understand. So in it goes. Thanks @agriyakhetarpal!
Description
At the time of writing, this PR intends to test out pypa/cibuildwheel#1456 for building WASM wheels with Python 3.12.1 and Emscripten 3.1.58.
Additional context
cibuildwheeldocumentation: https://cibuildwheel.pypa.io/en/latest/setup/#pyodide-webassembly-builds-experimental