Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DOC: highlighted deprecations with backward compatibility information #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2024
Merged

DOC: highlighted deprecations with backward compatibility information #778

merged 2 commits into from
Dec 4, 2024

Conversation

@meiyasan
Copy link
Contributor

@meiyasan meiyasan commented Nov 22, 2024 •
edited
Loading

Hello,

I wanted to suppress the deprecation warning when using the cmor continuous wavelet family in my code. Instead of removing the message entirely, I highlight the initial parameters of the deprecated wavelet names for reference.

Below is the code snippet I’m working with:

import pywt
wavelets = ["fbsp", "cmor", "shan"]
for wavelet in wavelets:
    w = pywt.ContinuousWavelet(wavelet)
    print(wavelet)
    print("M = ", w.fbsp_order)
    print("B = ", w.bandwidth_frequency)
    print("C = ", w.center_frequency)
    print("")

@meiyasan meiyasan changed the title highlighted deprecations with backward compatibility information DOC: highlighted deprecations with backward compatibility information Nov 22, 2024
agriyakhetarpal
agriyakhetarpal approved these changes Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @meiyasan!

@rgommers @agriyakhetarpal
Fix a few missing spaces
2722720 
Co-authored-by: Agriya Khetarpal <[email protected]>
@meiyasan
Copy link
Contributor Author

meiyasan commented Dec 4, 2024

@agriyakhetarpal @rgommers, are there any additional checks required?

@agriyakhetarpal
Copy link
Collaborator

I think this should be good to go, but it is @rgommers who can press the green button :)

@rgommers rgommers added this to the v1.8.0 milestone Dec 4, 2024
rgommers
rgommers approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @meiyasan. And thanks for the review @agriyakhetarpal

@rgommers rgommers merged commit 7d32750 into PyWavelets:main Dec 4, 2024
17 checks passed
@meiyasan meiyasan deleted the patch-1 branch December 5, 2024 01:11
gabalafou pushed a commit to gabalafou/pywt that referenced this pull request Dec 20, 2024
@meiyasan @gabalafou
DOC: highlighted deprecations with backward compatibility information (…
91dbde9 
…PyWavelets#778)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rgommers rgommers rgommers approved these changes

+1 more reviewer

@agriyakhetarpal agriyakhetarpal agriyakhetarpal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation maintenance

Projects

None yet

Milestone

v1.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@meiyasan @agriyakhetarpal @rgommers