Overhaul PyROS Preprocessor Subroutine and Subproblem Objects#3341
Merged
blnicho merged 233 commits intoPyomo:mainfrom Nov 6, 2024
Merged
Overhaul PyROS Preprocessor Subroutine and Subproblem Objects#3341blnicho merged 233 commits intoPyomo:mainfrom
blnicho merged 233 commits intoPyomo:mainfrom
Conversation
Contributor
Author
|
That's it for updates post #3382. |
mrmundt
approved these changes
Nov 4, 2024
Contributor
mrmundt
left a comment
There was a problem hiding this comment.
I don't have anything that actually needs to be changed, just some stylistic suggestions. Overall it looks good.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3341 +/- ##
==========================================
+ Coverage 88.57% 88.66% +0.08%
==========================================
Files 883 883
Lines 100343 100156 -187
==========================================
- Hits 88882 88800 -82
+ Misses 11461 11356 -105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2964.
Summary/Motivation:
Driven by recent algorithmic developments of the PyROS preprocessor, this PR implements sweeping changes to the PyROS preprocessor subroutine and subproblem formulations/object structures.
Changes proposed in this PR:
Update PyROS as follows:
UncertaintySetclass and pre-implemented subclasses to facilitate changes to the subproblemsUncertaintySet.set_as_constraintto make auxiliary uncertain parameters easier to trackCardinalitySetandFactorModelSetclassesFactorModelSetinstances to those for whichpsi_matis full column rankIntersectionSetcore.expr.compare.assertExpressionsEqual) for more precise model testingpoint_in_set,set_as_constraintTODO
ParameterizedQuadraticRepnand corresponding expression walker #3324 merged) useParameterizedQuadraticRepnVisitorin lieu ofgenerate_standard_repnLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: