Update custom widget example in docs #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
My only issue with this change is that it's combining string concatenation with |
Author
|
Fully agree, I updated the branch. |
Contributor
|
one more nitpick... :) http://legacy.python.org/dev/peps/pep-0008/#maximum-line-length instead of: you could do one of these: Basically you want to avoid the backslash because it breaks if there's any white space directly after it and white space is hard to notice at the end of a line. |
The example for a custom widget in the docs builds an input field like this:
return u'<input type="text" value="%s">' % quoted
But the `name` property is not set, so no data would be submitted for this field.
Author
|
Updated :) |
Contributor
|
@stevepiercy this should be merged. |
Member
|
@tsauerwein thank you! Sorry for the long delay. I've recently taken on the role of maintainer for Deform. |
stevepiercy
added a commit
to stevepiercy/deform
that referenced
this pull request
Aug 23, 2020
stevepiercy
added a commit
to stevepiercy/deform
that referenced
this pull request
Aug 23, 2020
(cherry picked from commit b7442ed)
stevepiercy
added a commit
that referenced
this pull request
Aug 23, 2020
Update widget docs per #226 for consistency across code examples
stevepiercy
added a commit
that referenced
this pull request
Aug 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example for a custom widget in the docs builds an input field like this:
But the
nameproperty is not set, so no data would be submitted for this field.