Fix #567 Ignore errors for invalid referenced definitions during compilation #569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amakhrov
reviewed
Jan 19, 2018
| ]); | ||
| $builder->enableCompilation(self::COMPILATION_DIR, self::generateCompiledClassName()); | ||
| $builder->build(); | ||
| } |
There was a problem hiding this comment.
The test name says throw an error - but there is no @expectedException annotation. Since the test passed, I guess no error is actually triggered in this case.
Am I just missing the point?
There was a problem hiding this comment.
Oh wait… You are right I iterated several times on the solution and in the end it's not working as expected, thanks for catching that!
By checking already compiled entries only, an entry *planned* to be compiled but not compiled yet would be overwritten. Its status would change from "it's an entry defined in the configuration" to "it's an entry we found through references in autowired entries", which would break one test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #567