Adds support for autowire of __construct for wildcards #616
Conversation
|
Thanks for the PR, you have actually spotted a bug! Wildcard definitions with autowiring are supposed to work in 6.x, and they work in simple scenarios. Your PR fixes the bug which is great. I think however there is a more elegant solution because your solution involves "normalizing" the definition twice. I've opened a PR on your PR in your repository ;) -> ArtFireCom#1 If you merge it into your branch then this pull request here will be updated and good to merge I think. |
|
Excellent! This was exactly the best case scenario I'd hoped for where,
|
|
Great. And woops it seems I missed an unused import (see https://github.com/PHP-DI/PHP-DI/pull/616/checks?check_run_id=13995093) would you have time to remove it? That way the build will be green and I'll be able to merge and release. |
|
Perfect thanks! |
In 5.x it was possible to have auto wiring of wildcard definitions via reflection, this PR enables that functionality again.
The "fix" might be a bit hacky however, as I wasn't able to find a cleaner way for ReflectionBasedAutowiring to be aware of what class to use reflection on, unless I sent the wildcard class through the normalizer a second time after the derived implementation class name was set.