support variadic parameter on addDefinitions #627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build error is coming from PHPStan This is the code /**
* Add definitions to the container.
*
* @param string[]|array[]|DefinitionSource[] $definitions Can be an array of definitions, the
* name of a file containing definitions
* or a DefinitionSource object.
* @return $this
*/
public function addDefinitions(...$definitions) : self
{
[...] |
|
Regarding the coding style I've added a commit on master to fix the coding style (Symfony added a new rule that breaks BC): a989248 If you merge/rebase master your PR should be OK. As for phpstan I think you don't need to update the types in the phpdoc, try this and see if it works: |
|
Finally! dockblock syntax on variadic arguments does not seam to be well documented |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per this comments: #618 (comment) #618 (comment)
Support variadic arguments when calling addDefinitions