Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Better error handling #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 22, 2013
Merged

Better error handling #65

merged 3 commits into from
May 22, 2013

Conversation

@mnapoli
Copy link
Member

@mnapoli mnapoli commented May 21, 2013

This is a merge of #64 with the following changes:

  • PHP-DI specific exceptions are catched and rethrown to have a nicer error message
  • other exceptions are not catched, which leaves the stack trace clean and gives the user the behavior he may expect (he may want to catch the exception)

cboden and others added 3 commits May 19, 2013 15:48
@mnapoli mnapoli mentioned this pull request May 21, 2013
Merged
@cboden
Copy link
Contributor

cboden commented May 22, 2013

👍

😏 One might say 😎... It was a nice catch
Yeeeeeeeaaaa

@domu1de
Copy link
Contributor

domu1de commented May 22, 2013

Looks good! (Y)

mnapoli added a commit that referenced this pull request May 22, 2013
@mnapoli
Merge pull request #65 from mnapoli/error-handling
f7252a2 
Better error handling
@mnapoli mnapoli merged commit f7252a2 into master May 22, 2013
@mnapoli
Copy link
Member Author

mnapoli commented May 22, 2013

Done! 3.0.2 is released and contains that change.

@mnapoli
Copy link
Member Author

mnapoli commented May 22, 2013

And thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mnapoli @cboden @domu1de