Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@angelxmoreno
Copy link
Contributor

Based on discussions in #754, replaced the default method for accessing environment variables.

@angelxmoreno angelxmoreno force-pushed the feature/754-replace-getenv branch from e146db9 to 5f4d3ba Compare December 29, 2020 14:46
@angelxmoreno
Copy link
Contributor Author

Applied the suggestions! Thanks so much guys for the review

Copy link
Member

@mnapoli mnapoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looking good!

The code sniffer build is failing though, if you can fix that I'll merge it!

@mnapoli
Copy link
Member

mnapoli commented Mar 25, 2021

We're all good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants