Make InvalidDefinition exception implement ContainerExceptionInterface #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, that looks very good, thank you for all the summary and coming up with a simple fix! |
|
I'd very much appreciate a release with this fix :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed the issue described in #772 in the most intrusive way I was able to find.
Another approach would be to catch
InvalidDefinitioninContainerand rethrowDependencyExceptionby wrapping the previous exception, however, this would break the backward compatibility ofContainerbecause it would throw an exception of different implementation (if users ofContainerclass catchInvalidDefinitionand we change the exception type we throw new exception type would bot be caught).Fixes #772