ContainerBuilder: fallback typehints for PhpStorm #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! These are a lot of annotations, couldn't we limit ourselves to reverting #842 for now? Maintaining all those annotations is not something I am looking for tbh :/ |
|
I don't think we need both |
Fixes PHP-DI#844. PhpStorm currently lacks the ability to infer a template type from a `class-string` constructor argument (see https://youtrack.jetbrains.com/issue/WI-65811/Infer-type-from-constructors-class-string-parameter). As a result of PHP-DI#842 (v7.0.1), this requires PhpStorm users to manually typehint their ContainerBuilder instances, e.g.: /** @var ContainerBuilder<Container> $builder */ $builder = new ContainerBuilder(); To avoid this, we only use the proper templated typehints with Psalm annotations (which will be usable by both Psalm and PHPStan), and leave the non-templated typehints as a fallback. Note that the fallbacks will not give the correct type when using a non-default Container class.
Good point, thanks! I've updated the PR to remove the
I understand completely. Do you feel the situation is sufficiently improved with the |
|
@hemberger yes that's better, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #844.
PhpStorm currently lacks the ability to infer a template type from a
class-stringconstructor argument (seehttps://youtrack.jetbrains.com/issue/WI-65811/Infer-type-from-constructors-class-string-parameter). As a result of #842 (v7.0.1), this requires PhpStorm users to manually typehint their ContainerBuilder instances, e.g.:
To avoid this, we only use the proper templated typehints with Psalm- and PHPStan-specific annotations, and leave the non-templated typehints as a fallback. Note that the fallbacks will not give the correct type when using a non-default Container class.
@Gounlaf While this should in theory recover the pre-7.0.1 behavior for PhpStorm, I'm not able to test this. Could you please check if it fixes your issue? Many thanks!