You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I liked the ?ObjectDefinition notation, are we able to configure the CS to use that?
How do you mean? What does that look like in comparison to ?ObjectDefinition $definition = null?
Also I'm not sure why the build fails now 😕
The CS fixer still fails because it no longer accepts return types like string|null and wants to replace them with ?string. There must have been a change in the default rules. This also affects other PRs like #886.
For this PR, I originally just ran php-cs-fixer fix and that also changed the return types. I reverted these changes in the second commit because that's a different topic, IMO. I can of course restore the return type changes to fix the CS build.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.4 deprecates implicitly nullable parameter types:
https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
The CS fixer rule
nullable_type_declaration_for_default_null_valuecan also be removed, astrueis its default value.Tests
I tried adding
8.4to the list of tested PHP versions inci.yml, but the package requirements can't be resolved yet: