Improve exception message on unknown method argument #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks really good thank you! |
mnapoli
added a commit
that referenced
this pull request
Jul 24, 2015
…efined-parameter Improve exception message on unknown method argument
|
Ah I just realized you made the PR against the |
|
@mnapoli thanks! Yes, we still haven't upgraded to 5.0 so having new version tag in 4.x would be very helpful! |
|
@mnapoli just checking in here: any ETA on new version tag for 4.x? |
|
Done, sorry for the delay :) https://github.com/PHP-DI/PHP-DI/releases/tag/4.4.9 |
|
no worries! Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Sometimes when class implementation changes and container definition is out of date it really gets hard to debug where is the issue. Currently exception message contains this:
Also it throws
\ReflectionExceptioncurrently. There is nothing in the stack trace which can help in finding invalid definition as well.This PR improves this situation by:
DefinitionExceptionwhich makes more sense since we actually have invalid container definition.