Add a remote call for task completion for plugins running on craned #378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-Xiafeng
requested changes
Dec 1, 2024
Nativu5
reviewed
Dec 2, 2024
db7f0ad to
49e2fa8
Compare
RileyWen
reviewed
Dec 3, 2024
RileyWen
reviewed
Dec 3, 2024
Collaborator
|
其他我目前没啥问题 |
RileyWen
reviewed
Dec 4, 2024
RileyWen
reviewed
Dec 5, 2024
| using crane::grpc::plugin::CreateCgroupHookReply; | ||
| using crane::grpc::plugin::CreateCgroupHookRequest; | ||
|
|
||
| auto request = dynamic_cast<CreateCgroupHookRequest*>(msg); |
Collaborator
There was a problem hiding this comment.
类型改成auto *，然后dynamic_cast 有可能为空指针，加个CRANE_ASSERT(request != nullptr);这样的语句
RileyWen
reviewed
Dec 5, 2024
Collaborator
|
LGTM. 可以准备合并了。 |
Nativu5
approved these changes
Dec 6, 2024
L-Xiafeng
approved these changes
Dec 6, 2024
huerni
pushed a commit
that referenced
this pull request
Jan 7, 2025
…378) * Add a remote call for task completion for plugins running on craned * update CreateCgroupHookRequest proto struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.