fix: Fix append regression in 0.13.5 #5495
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a regression in the append functionality introduced in version 0.13.5. The fix addresses issue #5494 by improving the positional mapping logic for UNION operations in SQL generation.
- Adds bounds checking to prevent invalid array access when applying positional mappings
- Ensures positional mappings are only stored when complete (all columns matched)
- Adds defensive programming with logging for better debugging
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| prqlc/prqlc/src/sql/pq/positional_mapping.rs | Core fix adding bounds validation and completeness checks for positional mappings |
| prqlc/prqlc/tests/integration/queries/append_cte_complex.prql | New test case demonstrating complex append scenarios with CTEs |
| Multiple snapshot files | Updated test snapshots reflecting the regression fix and new test additions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
thanks @priithaamer . sorry for the regression. let's merge? or any other feedback? |
Merged
|
I did the same re reducing the integration tests for this — https://github.com/max-sixty/prql/tree/fix-5494-append-regression (or I can push to this MR with perms) |
|
@priithaamer Could you take a look at this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #5494