feat: Add support for Redshift dialect #5537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priithaamer
commented
Oct 31, 2025
| let ident = ident.to_ascii_uppercase(); | ||
|
|
||
| sql_keywords().contains(ident.as_str()) | ||
| sql_keywords().contains(ident.as_str()) || dialect_keywords(dialect).contains(ident.as_str()) |
Contributor
Author
There was a problem hiding this comment.
I'm a bit unsure about this but does not seem to have any side-effects and opens the capability to selectively escape keywords when used as column names.
Member
|
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not 100% complete support, but solves major blockers using Redshift:
DISTINCT ONbeing used forgroup ... take 1deduplication.