fix(redshift): use || operator over CONCAT for std.concat #5540
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Redshift docs state that one should use nested CONCAT functions or the `||` operator to concatenate more than two elements: https://docs.aws.amazon.com/redshift/latest/dg/r_CONCAT.html Signed-off-by: Luka Peschke <[email protected]>
Signed-off-by: Luka Peschke <[email protected]>
Contributor
|
Awesome, thanks! It has been bugging us as well but haven't gotten to it yet. Can confirm it works! |
Member
|
Thank you both, let's merge this. |
Member
|
lmk if you want me to do a release; quite easy to do now! |
Contributor
Author
|
@max-sixty A release would be great once #5545 is merged! It's the last blocker for our prql+redshift usage :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for @priithaamer 's work on the Redshift dialect (thanks!). I'm getting the following error from Redshift when usingg f-strings:
[SQLState 42883] ERROR: function concat(character varying, "unknown", character varying) doe s not existThe Redshift docs state that one should use nested CONCAT functions or the
||operator to concatenate more than two elements: https://docs.aws.amazon.com/redshift/latest/dg/r_CONCAT.html