fix: Provide clear error for empty tuple/array in from #5564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace panic with user-friendly error message when using `from {}` or `from []`.
Previously, the compiler would panic with "called Option::unwrap() on a None value"
when empty tuples or arrays were used as table arguments. Now it provides a clear
error message explaining that empty tuples/arrays cannot be used as tables.
The fix properly distinguishes between:
- Empty tuples/arrays used directly (shows clear error)
- Empty arrays from functions like std.from_text that set lineage (works correctly)
Closes PRQL#4317
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4317 by replacing panic with a user-friendly error message when using
from {}orfrom [].Changes
prqlc/prqlc/src/semantic/resolver/functions.rsto detect empty tuples/arrays and provide clear error messagesbad_error_messages.rsto expect new error formatBefore
After
Test Plan
from {}andfrom []casesstd.from_textwith empty data (which properly sets lineage)🤖 Generated with Claude Code