fix: Add ORDER BY fallback for Snowflake window functions #5583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snowflake requires an ORDER BY clause for ranking window functions like ROW_NUMBER(). This adds `ORDER BY 1` as a fallback when no explicit sort is specified. Fixes PRQL#5580 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ORDER BY 1fallback for Snowflake window functions when no explicit sort is specifiedrequires_order_by_in_window_function()method toDialectHandlertraitFixes #5580
Test plan
test_snowflake_row_number_requires_order_by- verifies ORDER BY 1 is added when no sort specifiedtest_snowflake_row_number_with_explicit_sort- verifies user-provided sort is preserved🤖 Generated with Claude Code