feat: Added support for read_json for duckdb and clickhouse
#5608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
- Replace large albums.json (1737 lines) with minimal media_types.json (5 records) - Combine read_json test into existing read_csv.prql using append - Add inline tests for DuckDB, ClickHouse, and generic dialects - Fix docs example to use explicit join conditions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
read_json for duckdb and clickhouseread_json for duckdb and clickhouse
Member
|
@adamnemecek I pushed a bunch of changes, hope that's OK! thanks a lot for starting this, great work |
Member
|
(adding a function to the stdlib causes all the ids to increment, hence the very large diff...) |
Contributor
Author
Thanks a lot! In fact, I was hoping someone would pick up the torch since I knew there were things that were missing but I wasn't sure what to add as there is a lot going on. |
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Member
very easy for me to finish it off! feel free to do this again if you have anything to add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DuckDB target didn't expose
read_json, despite exposingread_csvandread_parquet.It is unclear to me how I am supposed to add a test.
I tested it using this bash script
I tested only DuckDB.