Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: text.length on Snowflake #5614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-sixty merged 1 commit into from
Dec 15, 2025
Merged

fix: text.length on Snowflake #5614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions prqlc/prqlc/src/sql/std.sql.prql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,4 +392,10 @@ module snowflake {
# https://docs.snowflake.com/en/sql-reference/operators-arithmetic#division
@{binding_strength=11}
let div_f = l r -> s"({l} / {r:12})"

# Text functions
module text {
# https://docs.snowflake.com/en/sql-reference/functions-string
let length = column -> s"LENGTH({column:0})"
}
}
17 changes: 17 additions & 0 deletions prqlc/prqlc/tests/integration/sql.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6622,6 +6622,23 @@ fn test_snowflake_row_number_with_explicit_sort() {
"#);
}

#[test]
fn test_snowflake_text_length_uses_length() {
// Snowflake should use LENGTH instead of CHAR_LENGTH
assert_snapshot!(compile_with_sql_dialect(r###"
from employees
select {
name_length = (name | text.length)
}
"###, sql::Dialect::Snowflake
).unwrap(), @r#"
SELECT
LENGTH("name") AS "name_length"
FROM
"employees"
"#);
}

#[test]
fn test_group_with_only_sort() {
// Issue #5092: group with only sort (no take) should not cause ICE.
Expand Down