Replace one interchange task counter with task_id #4013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this PR, the interchange had two task counters. The one removed by this PR was used to: i) disambiguate tasks of equal priority - in effect using the counter as yet another task identifier, distinct from the Parsl or HTEX task IDs. ii) log how many tasks have been received by the interchange This PR removes that counter: i) tasks of equal priority are disambiguated by their HTEX-level task_id. It is already a protocol requirement that different tasks have different task IDs. ii) The total tasks received log message is replaced by per-task logging at the same place which makes it clear *which* tasks have been received, instead of recording the count received. In debugging task flow, this has been more useful to me.
khk-globus
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR, the interchange had two task counters. The one removed by this PR was used to:
i) disambiguate tasks of equal priority - in effect using the counter
as yet another task identifier, distinct from the Parsl or HTEX
task IDs.
ii) log how many tasks have been received by the interchange
This PR removes that counter:
i) tasks of equal priority are disambiguated by their HTEX-level task_id. It is already a protocol requirement that different tasks have different task IDs.
ii) The total tasks received log message is replaced by per-task logging at the same place which makes it clear which tasks have been received, instead of recording the count received. In debugging task flow, this has been more useful to me.
Changed Behaviour
Tasks of equal priority might be differently disambiguated now, but probably not -- in general tasks will arrive in task_id order. Equal priority tasks, by definition, have no expected relative execution order, though.
Type of change