-
Notifications
You must be signed in to change notification settings - Fork 108
feat: switch to use new pipeline trigger by prow in branch 7.1 #3136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: switch to use new pipeline trigger by prow in branch 7.1 #3136
Conversation
Based on the PR title and description, it seems that this pull request is switching to use a new pipeline trigger by Prow in branch 7.5 for tikv and tiflash. From the diff provided, it looks like the changes are mainly updating the blacklist target branches for the GHPR build, integration test, and unit test jobs for tiflash and tikv. It also includes changes to the release-7.1-presubmits.yaml files for tiflash and tikv. One potential problem I see is that this PR is only updating the blacklist target branches for release-7.1 in the GHPR build, integration test, and unit test jobs for tiflash and tikv. However, the changes in this PR are related to branch 7.5, so it's possible that other jobs may need to be updated as well. It's recommended to check if other jobs need to be updated too. Also, the changes in the release-7.1-presubmits.yaml files for tiflash and tikv seem to be unrelated to the changes mentioned in the PR title and description. It's recommended to split them into a separate PR to make it easier to review and merge. As for fixing suggestions, it's recommended to check if other jobs need to be updated as well and update them accordingly. Additionally, it's recommended to split the changes in the release-7.1-presubmits.yaml files into a separate PR to make it easier to review and merge. |
|
/hold |
|
@purelind: GitHub didn't allow me to request PR reviews from the following users: /cc, zhangjinpeng1987. Note that only PingCAP-QE members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@glorv: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Lloyd-Pottiger: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@zanmato1984: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: glorv, JaySon-Huang, Lloyd-Pottiger, wuhuizuo, zanmato1984 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Based on the pull request title and description, it seems that the changes are related to switching to a new pipeline trigger by Prow in the tikv and tiflash branch release-7.1. The changes include adding release-7.1 branch to the blacklist of some Jenkins jobs and updating the presubmits.yaml files for tiflash and tikv to use the new trigger. However, there are some potential problems with the changes. Firstly, the pull request does not include any tests to confirm that the changes work as expected. Secondly, it is not clear why the release-7.1 branch is being blacklisted in some Jenkins jobs. This may cause issues if there are changes that need to be tested in this branch. To fix these issues, some suggestions are:
|
|
/unhold |
Swtich to use new pipeline trigger by prow in tikv & tiflash branch release-7.1