Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@purelind
Copy link
Collaborator

@purelind purelind commented Sep 24, 2024

Swtich to use new pipeline trigger by prow in tikv & tiflash branch release-7.1

@ti-chi-bot ti-chi-bot bot requested a review from wuhuizuo September 24, 2024 07:42
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 24, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and description, it seems that this pull request is switching to use a new pipeline trigger by Prow in branch 7.5 for tikv and tiflash.

From the diff provided, it looks like the changes are mainly updating the blacklist target branches for the GHPR build, integration test, and unit test jobs for tiflash and tikv. It also includes changes to the release-7.1-presubmits.yaml files for tiflash and tikv.

One potential problem I see is that this PR is only updating the blacklist target branches for release-7.1 in the GHPR build, integration test, and unit test jobs for tiflash and tikv. However, the changes in this PR are related to branch 7.5, so it's possible that other jobs may need to be updated as well. It's recommended to check if other jobs need to be updated too.

Also, the changes in the release-7.1-presubmits.yaml files for tiflash and tikv seem to be unrelated to the changes mentioned in the PR title and description. It's recommended to split them into a separate PR to make it easier to review and merge.

As for fixing suggestions, it's recommended to check if other jobs need to be updated as well and update them accordingly. Additionally, it's recommended to split the changes in the release-7.1-presubmits.yaml files into a separate PR to make it easier to review and merge.

@purelind
Copy link
Collaborator Author

/hold

@purelind purelind changed the title feat: switch to use new pipeline trigger by prow in branch 7.5 feat: switch to use new pipeline trigger by prow in branch 7.1 Sep 24, 2024
@purelind
Copy link
Collaborator Author

tiflash

image image ## tikv image

@purelind
Copy link
Collaborator Author

purelind commented Sep 25, 2024

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 25, 2024

@purelind: GitHub didn't allow me to request PR reviews from the following users: /cc, zhangjinpeng1987.

Note that only PingCAP-QE members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc /cc @Lloyd-Pottiger @JaySon-Huang @zanmato1984 @glorv @zhangjinpeng1987

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 25, 2024

@glorv: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 25, 2024

@Lloyd-Pottiger: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 25, 2024

@zanmato1984: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Collaborator

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Sep 25, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 25, 2024

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, JaySon-Huang, Lloyd-Pottiger, wuhuizuo, zanmato1984

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 26, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the changes are related to switching to a new pipeline trigger by Prow in the tikv and tiflash branch release-7.1. The changes include adding release-7.1 branch to the blacklist of some Jenkins jobs and updating the presubmits.yaml files for tiflash and tikv to use the new trigger.

However, there are some potential problems with the changes. Firstly, the pull request does not include any tests to confirm that the changes work as expected. Secondly, it is not clear why the release-7.1 branch is being blacklisted in some Jenkins jobs. This may cause issues if there are changes that need to be tested in this branch.

To fix these issues, some suggestions are:

  1. Add tests to confirm that the changes work as expected.
  2. Provide more information on why the release-7.1 branch is being blacklisted in some Jenkins jobs. Consider removing the blacklisting if it is not necessary.
  3. Consider adding more details to the pull request description to help other reviewers understand the changes better.

@purelind
Copy link
Collaborator Author

/unhold

@purelind purelind added the lgtm label Sep 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit 0d76147 into PingCAP-QE:main Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants