Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(tiflow): tiflow master bump go version to 1.23 #3137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2024
Merged

feat(tiflow): tiflow master bump go version to 1.23 #3137

merged 1 commit into from
Oct 8, 2024

Conversation

@purelind
Copy link
Collaborator

@purelind purelind commented Sep 24, 2024

tiflow master bump go version to 1.23

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 24, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot requested a review from wuhuizuo September 24, 2024 09:34
@ti-chi-bot ti-chi-bot bot added the size/S label Sep 24, 2024
@purelind purelind marked this pull request as ready for review October 8, 2024 02:27
@purelind
Copy link
Collaborator Author

purelind commented Oct 8, 2024

/hold

wait for PR pingcap/tiflow#11607 ready

Benjamin2037
Benjamin2037 approved these changes Oct 8, 2024
View reviewed changes
Copy link

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 8, 2024

@Benjamin2037: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@purelind
Copy link
Collaborator Author

purelind commented Oct 8, 2024

/unhold

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: Benjamin2037

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit e5637f1 into PingCAP-QE:main Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wuhuizuo wuhuizuo Awaiting requested review from wuhuizuo

1 more reviewer

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved area/jenkins-pipelines lgtm size/S

Projects

EE - CI/CD system
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@purelind @Benjamin2037