feat: show tag counter on admin pages#2349
Open
nathanaelhoun wants to merge 2 commits intoPiwigo:masterfrom
Open
feat: show tag counter on admin pages#2349nathanaelhoun wants to merge 2 commits intoPiwigo:masterfrom
nathanaelhoun wants to merge 2 commits intoPiwigo:masterfrom
Conversation
Tested on: - mariadb: 11.4.5 - mysql: 5.6.51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To help me merge similar tags I have in my setup, I wanted to see which one was the more used.
By exploring the code, I saw that the number of images was already fetched, but not shown. I figured it could be useful for anybody to show it on the admin page.
After :
I also saw an opportunity for an optimization here. According to my measurements (5000+ photos, 200+ tags), the performance benefit is not huge but there.