Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Naramsim
Copy link
Member

Allows triggering deployments only when the master branch gets pushed

@Naramsim Naramsim requested review from a team and Kronopt April 26, 2020 14:54
Copy link
Member

@cmmartti cmmartti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Did you test that it works?

@Naramsim
Copy link
Member Author

Looks good to me. Did you test that it works?

I didn't test it but that's how the documentation shows. Anyway, we will see right now 😄.

@Naramsim Naramsim merged commit dd54d13 into master Apr 26, 2020
@Naramsim Naramsim deleted the circle-ci-deploy branch April 26, 2020 16:46
@Naramsim
Copy link
Member Author

Ok, it turns out that artifacts are attached to individual jobs and not to projects. So by using the latest tag, we are fetching the artifacts of the deploy job which does not produce any of them.

Instead, it is the build job that produces the artifacts.

So I suggest to merge the build and deploy phase

@Naramsim
Copy link
Member Author

Naramsim commented Apr 26, 2020

Ok, so they are deployed if the store_artifacts command is part of the last job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants