Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Naramsim
Copy link
Member

No description provided.

@Naramsim Naramsim requested a review from cmmartti April 26, 2020 17:37
@Naramsim
Copy link
Member Author

We can squash

@Naramsim Naramsim merged commit b095782 into master Apr 26, 2020
@Naramsim Naramsim deleted the circle-ci-deploy branch April 26, 2020 17:41
@Naramsim
Copy link
Member Author

@Naramsim
Copy link
Member Author

Naramsim commented Apr 26, 2020

What I fear now is that maybe pushing to branches other than master will generate new jobs and those jobs will be marked as latest and will not carry any artifacts.

I'll try to push a new branch just to check

@cmmartti
Copy link
Member

Could we use GitHub Actions for this instead? It wasn't public when we first set up CircleCI, and it might make things easier. I've never used it, so I don't know.

@Naramsim
Copy link
Member Author

Ok, pushing to new branches doesn't change the latest artifact on this URL: https://circleci.com/api/v1.1/project/github/PokeAPI/api-data/latest/artifacts?branch=master so the querystring works well.

Could we use GitHub Actions for this instead? It wasn't public when we first set up CircleCI, and it might make things easier. I've never used it, so I don't know.

In my opinion, we should stick for now with CircleCI. We use it on all the projects and now works well. In a few days (when I will open the definitive PR) we will also have the updater bot running there. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants