Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mattgoud
Copy link
Collaborator

@mattgoud mattgoud commented Apr 7, 2025

❓ Types of changes

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • πŸ“¦ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • fix [BUG] Select width and heightΒ #431
  • additionnal changes:
  • improve responsive behavior (select input)
  • update gitignore and remove auto-generated components.d.ts files by unplugin-vue-components

πŸ“ Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@mattgoud mattgoud linked an issue Apr 7, 2025 that may be closed by this pull request
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • docs/vitepress/.gitignore: Language not supported
  • packages/theme/src/puik-select.scss: Language not supported
  • playground/.gitignore: Language not supported
Comments suppressed due to low confidence (1)

packages/components/select/src/select.vue:57

  • Inserting a
    inside a element may violate HTML semantics; consider using an inline element like or restructuring the markup to ensure valid HTML.
<div class="puik-multi-select__options-tags--container">

@mattgoud mattgoud closed this Apr 8, 2025
@mattgoud mattgoud reopened this Apr 8, 2025
@mattgoud mattgoud merged commit b7726f4 into main Apr 8, 2025
6 of 7 checks passed
@mattgoud mattgoud deleted the 431-bug-select-width-and-height branch April 8, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Select width and height

2 participants