Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: [chip-style] fix #466 - apply new style #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 1, 2025
Merged

feat: [chip-style] fix #466 - apply new style #469

merged 4 commits into from
Sep 1, 2025

Conversation

@mattgoud
Copy link
Collaborator

@mattgoud mattgoud commented Aug 28, 2025 •
edited
Loading

❓ Types of changes

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

fix #466 :

  • add border and border-radius
  • text with font-weight medium
  • ⚠️ BC : remove small variant (now the default variant corresponds to the old small variant) and create large variant.

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@mattgoud
feat: [chip-style] fix #466 - apply new style (add border and border-…
8c476dd 
…radius, text with font-weight medium - see figma link in #466)
@mattgoud mattgoud requested a review from housnihousni August 28, 2025 13:55
@mattgoud mattgoud self-assigned this Aug 28, 2025
@mattgoud mattgoud added the style label Aug 28, 2025
@mattgoud mattgoud linked an issue Aug 28, 2025 that may be closed by this pull request
[Design] Review Chip style #466
Closed
@mattgoud
feat: [new-chip-style] fix #466 - BC size prop : remove small value a…
3f97a73 
…nd create large value, increase font-size for large size, update test and stories
@mattgoud
feat: #related #466 [new-chip-style][select-multiple] fix size of chi…
9c61cc1 
…ps for selected options
@mattgoud mattgoud added breaking change enhancement New feature or request documentation Improvements or additions to documentation labels Aug 29, 2025
@mattgoud mattgoud merged commit e3b66c6 into main Sep 1, 2025
5 checks passed
@mattgoud mattgoud deleted the 466-design-review-chip-style branch September 1, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@housnihousni housnihousni Awaiting requested review from housnihousni

Assignees

@mattgoud mattgoud

Labels

breaking change documentation Improvements or additions to documentation enhancement New feature or request style

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Design] Review Chip style

2 participants

@mattgoud