Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: [modal] fix #297 #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 4, 2025
Merged

feat: [modal] fix #297 #473

merged 4 commits into from
Sep 4, 2025

Conversation

@mattgoud
Copy link
Collaborator

@mattgoud mattgoud commented Sep 4, 2025 •
edited
Loading

❓ Types of changes

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • 📦 New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

fix #297 :

  • add props to handle the disabled state of buttons
  • [storybook] update modal stories
  • [style] fix modal title width

📝 Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes
  • The component exists on old Prestashop UIKit and my pull request on migrating documentation is accepted.

@mattgoud mattgoud self-assigned this Sep 4, 2025
@mattgoud mattgoud added the documentation Improvements or additions to documentation label Sep 4, 2025
@mattgoud mattgoud linked an issue Sep 4, 2025 that may be closed by this pull request
[Modal] add props to handle the disabled state of buttons #297
Closed
@mattgoud mattgoud added enhancement New feature or request style labels Sep 4, 2025
@mattgoud mattgoud force-pushed the 297-feature-puikmodale branch from 38b5f84 to 7434d18 Compare September 4, 2025 17:18
@mattgoud mattgoud merged commit 6c5c756 into main Sep 4, 2025
5 checks passed
@mattgoud mattgoud deleted the 297-feature-puikmodale branch September 4, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mattgoud mattgoud

Labels

documentation Improvements or additions to documentation enhancement New feature or request style

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Modal] add props to handle the disabled state of buttons

2 participants

@mattgoud