Adjust the way that test observation suspension works. #486
Conversation
52ecf67 to
0223ec3
Compare
|
Well, I take back that part about avoiding private APIs... Unfortunately it seems that I'm not thrilled about needing to do this sort of hackery, but I don't have any other workarounds in mind at this point. |
Modify the internal set of observers managed by XCTestObservationCenter to not include XCTest's own observers while performing the suspension. This allows user-provided observers to remain in place, which is needed for Nimble to work properly now.
0223ec3 to
6105748
Compare
Adjust the way that test observation suspension works.
|
Sorry to keep you waiting, @briancroom! This looks great. I'm also not thrilled about all the hoops we jump through to support |
| @implementation XCTestObservationCenter (QCKSuspendObservation) | ||
|
|
||
| static BOOL (^isFromApple)(id, BOOL *) = ^BOOL(id observer, BOOL *stop){ | ||
| return [[NSBundle bundleForClass:[observer class]].bundleIdentifier containsString:@"com.apple.dt.XCTest"]; |
There was a problem hiding this comment.
nit-pick: As a maintainer I would love an inline comment here describing why this isApple predicate is necessary. I understand I can git blame and find this pull request, but hand waves code locality something something.
|
Thanks for the review and good points @modocache and @sharplet! I've pushed a commit addressing these things to master. |
When I updated the Nimble submodule to fix compilation on Xcode 7.3, I discovered that the changes made in Quick/Nimble#244 break the Quick tests because of the way that we use
+[XCTestObservationCenter _suspendObservationForBlock:]to enable runningXCTestSuiteinstances during the middle of an existing run. The problem is that Nimble now relies on a test observer of its own in order to be able to report failures to XCTest (see the CI failure here).This PR changes the
QCKSpecRunnerbehavior so that, instead of using private API on XCTestObservationCenter, it swizzles public methods to keep track of XCTest's own observers, then temporarily removes them from the center to implement the suspension behavior. I'm not convinced that this is necessarily any more future-proof than the old mechanism, because it relies on being able to add and remove observers at arbitrary times during an ongoing test run, but it does work with current XCTest versions, at least.Any concerns, @Quick/contributors?