Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix NSInternalInconsistencyException when running a test from test navigator #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2018
Merged

Fix NSInternalInconsistencyException when running a test from test navigator #716

merged 1 commit into from
Jul 4, 2018

Conversation

@haitaoli
Copy link
Contributor

@haitaoli haitaoli commented Jun 27, 2017 •
edited
Loading

If you select only one test case to run in xcode test navigator, the test can fail with error:

'NSInternalInconsistencyException', reason: ''beforeEach' cannot be used inside 'it', 'beforeEach' may only be used inside 'context' or 'describe'. ', userInfo: '(null)'

During test run world.currentExampleMetadata is set to current example, but it's never cleared. So once an example runs, no beforeEach can be called after it.

  • What behavior was changed?
    Before the example finishes running, clear Clear world.currentExampleMetadata.
  • What code was refactored / updated to support this change?
    Example.run()
  • What issues are related to this PR? Or why was this change introduced?

Checklist - While not every PR needs it, new features should consider this list:

  • Does this have tests?
  • Does this have documentation?
  • Does this break the public API (Requires major version bump)?
  • Is this a new feature (Requires minor version bump)?

@QuickBot
Copy link

1 Warning
⚠️ Need to add an unit test if you’re modifying swift source

Generated by 🚫 danger

@ikesyo
Copy link
Member

ikesyo commented Sep 9, 2017

Sorry for the late response, but I'm not sure what you are suffering from. Could you provide a reproducible case (project)?

@haitaoli
Copy link
Contributor Author

@ikesyo you don't need a repro project. Just try running one test case from xcode test navigator.

@ikesyo
Copy link
Member

ikesyo commented Sep 23, 2017

@haitaoli Fortunately (or unfortunately?) I can't reproduce it.

@ikesyo ikesyo mentioned this pull request Jul 4, 2018
Closed
1 task
ikesyo
ikesyo approved these changes Jul 4, 2018
View reviewed changes
Copy link
Member

@ikesyo ikesyo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the change is needed to make Xcode 10's parallel testing feature working. So Let's go ahead! 🚀

@ikesyo ikesyo merged commit 89699db into Quick:master Jul 4, 2018
@ikesyo ikesyo mentioned this pull request Jul 4, 2018
Merged
@haitaoli
Copy link
Contributor Author

haitaoli commented Jul 5, 2018

Thanks!

@ikesyo ikesyo mentioned this pull request Jul 12, 2018
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikesyo ikesyo ikesyo approved these changes

+1 more reviewer

@0802818176 0802818176 0802818176 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@haitaoli @QuickBot @ikesyo @0802818176