Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Migration swift 4.0 or later for Shared Examples. #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2020
Merged

Migration swift 4.0 or later for Shared Examples. #946

merged 1 commit into from
Feb 12, 2020

Conversation

@kanari3
Copy link
Contributor

@kanari3 kanari3 commented Feb 10, 2020

Updated to work with swift 4.0 and later.

Checklist - While not every PR needs it, new features should consider this list:

  • Does this have tests?
  • Does this have documentation?
  • Does this break the public API (Requires major version bump)?
  • Is this a new feature (Requires minor version bump)?

@kanari3 kanari3 force-pushed the feature/update_swift_sample branch from 4f5cf7a to 7c524de Compare February 10, 2020 08:48
@kanari3 kanari3 requested a review from takecian February 10, 2020 09:56
ikesyo
ikesyo approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@ikesyo ikesyo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refs:

LGTM, thanks for the fix 👍

@ikesyo ikesyo merged commit f26a21e into Quick:master Feb 12, 2020
@kanari3 kanari3 deleted the feature/update_swift_sample branch February 12, 2020 04:52
@kanari3
Copy link
Contributor Author

kanari3 commented Feb 12, 2020

Thanks for refs!

@ikesyo ikesyo mentioned this pull request Feb 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ikesyo ikesyo ikesyo approved these changes

@takecian takecian Awaiting requested review from takecian

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kanari3 @ikesyo