Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Description Please include a summary of the changes and the related issue. Please also include relevant motivation and context. ## Checklist before requesting a review Please delete options that are not relevant. - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my code - [ ] I have commented hard-to-understand areas - [ ] I have ideally added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged ## Screenshots (if appropriate): --------- Co-authored-by: aminediro <[email protected]>
…r into release/feat/quivr-core-0.1
AmineDiro
requested changes
Aug 9, 2024
|
|
||
| alter table "public"."knowledge" add column "file_sha1" text; | ||
|
|
||
| alter table "public"."knowledge" add column "metadata_" jsonb; |
Collaborator
There was a problem hiding this comment.
"metadata" column is already in knowledge, do we need to recreate with different name ? If this is an sqlmodel conflict. Their is a way to point a field to a column with different name
Contributor
Author
There was a problem hiding this comment.
I first added it as metadata but it gives an error, apparently i don't have the right to call it metadata so i changed it to metadata_
backend/api/quivr_api/modules/brain/integrations/Multi_Contract/Brain.py
Outdated
Show resolved
Hide resolved
chloedia
commented
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix core-142